Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix benchmarks #2669

Merged
merged 2 commits into from
Mar 2, 2022
Merged

Fix benchmarks #2669

merged 2 commits into from
Mar 2, 2022

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Feb 25, 2022

Fixing benchmarks requires bunch of NFData instance.

Many orphans have been moved to cardano-base, which means we need to get IntersectMBO/cardano-base#260 be merged for this PR

Also removed old symlinks.

@lehins lehins requested a review from nc6 February 25, 2022 14:45
@lehins lehins force-pushed the lehins/fix-benchmarks branch 2 times, most recently from 3db6c82 to fec819f Compare February 25, 2022 16:04
@lehins lehins requested a review from JaredCorduan March 2, 2022 14:22
JaredCorduan
JaredCorduan reviewed Mar 2, 2022
View reviewed changes
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, provided there is a good reason to disable the benchmarks on the alonzo tx deserialization

@lehins lehins merged commit f27ef22 into master Mar 2, 2022
@iohk-bors iohk-bors bot deleted the lehins/fix-benchmarks branch March 2, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredCorduan JaredCorduan JaredCorduan approved these changes

@nc6 nc6 Awaiting requested review from nc6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lehins @JaredCorduan